fix: don't ignore schemas of contained resources #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogversioning
approved these changes
Apr 26, 2024
If a field appears in {"contained": [{my resource fields}]}, it will
now also appear in the resulting schema.
If multiple resources are in the contained list, we'll use all the
relevant resource schema to find the column schema for mentioned
fields. This is slightly janky, but it's not clear how else to
handle this without pulling resources out of the contained list.
A project for the future.
mikix
force-pushed
the
mikix/contained-schema
branch
from
7b874be to
a027410
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a field appears in {"contained": [{my resource fields}]}, it will now also appear in the resulting schema.
If multiple resources are in the contained list, we'll use all the relevant resource schema to find the column schema for mentioned fields. This is slightly janky, but it's not clear how else to handle this without pulling resources out of the contained list. A project for the future.